Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SCM section to pom.xml #1496

Merged
merged 1 commit into from
Mar 28, 2023
Merged

Add SCM section to pom.xml #1496

merged 1 commit into from
Mar 28, 2023

Conversation

basil
Copy link
Member

@basil basil commented Mar 27, 2023

A future Maven multi-module aware version of PCT will require that every plugin has an <scm> section in its root pom.xml file. This PR proactively prepares this plugin to comply. The child.scm.*.inherit.append.path gibberish is part of the archetype and a standard practice in the Jenkins ecosystem for multi-module plugins to work around a surprising Maven behavior.

basil added a commit to jenkinsci/plugin-compat-tester that referenced this pull request Mar 27, 2023
@basil
Copy link
Member Author

basil commented Mar 27, 2023

Build is green

@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Merging #1496 (8335a08) into master (542c82a) will increase coverage by 0.18%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1496      +/-   ##
============================================
+ Coverage     81.64%   81.83%   +0.18%     
- Complexity     1399     1403       +4     
============================================
  Files           247      247              
  Lines          5334     5334              
  Branches        397      397              
============================================
+ Hits           4355     4365      +10     
+ Misses          858      850       -8     
+ Partials        121      119       -2     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@uhafner uhafner added the internal Internal changes without user or API impact label Mar 28, 2023
@uhafner uhafner merged commit 3bcb823 into jenkinsci:master Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Internal changes without user or API impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants